Fix #45, #63: Completion text replacement bugs #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change resolves a general class of issues around code completions coming from the language service. The JSON protocol allows the language server to specify the range of code that will get replaced by a completion item. Previously this range was being computed incorrectly. We now use the replacement range given by the PowerShell API. This also resolves PowerShell/vscode-powershell issues 45 and 12
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
…tweaks Addresses issues PowerShell#62 and PowerShell#63 in snippets file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resolves a general class of issues around code completions
coming from the language service. The JSON protocol allows the language
server to specify the range of code that will get replaced by a completion
item. Previously this range was being computed incorrectly. We now use
the replacement range given by the PowerShell API.
This also resolves PowerShell/vscode-powershell issues 45 and 12